Commit graph

648 commits

Author SHA1 Message Date
Paolo Amadini
76ef799b86 Bug 1440333 - Part 2 - Rename the "current" attribute to "visible". r=Gijs
MozReview-Commit-ID: EazXDT6JC3M

--HG--
extra : rebase_source : 5cca4cd0cf565ffbdf75a9777dfc15b359dcda57
2018-02-23 15:54:08 +00:00
Masayuki Nakano
cf83ee7bb4 Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.

MozReview-Commit-ID: De4enbjux3T

--HG--
extra : rebase_source : 2296b84bff8e22f01eeb48cd8614fac5db11136a
2018-02-15 04:15:39 +09:00
Masayuki Nakano
8917ac460f Bug 1436926 - part 2: Remove unnecessary KeyboardEvent.code specification of callers of EventUtils.synthesizeKey() r=smaug
Now, callers of EventUtils.synthesizeKey() don't need to specify
KeyboardEvent.code value anymore if they assume that active keyboard layout
is US keyboard layout.

Note that this patch changes the meaning of only test_bug551434.html.
Some callers in it don't match the key value and code value but that looks
like that they don't checking such odd keyboard events.  So, they must be
bug of the test.

MozReview-Commit-ID: Itxo7yZ9rkK

--HG--
extra : rebase_source : 856ef3715c924ca16e993ea57d92d1243b5cc6be
2018-02-09 19:17:26 +09:00
Edouard Oger
626be20bbb Bug 1427674 - Unify FxA content server URL preferences. r=markh,tcsc
MozReview-Commit-ID: 3zhHGAzQr0R

--HG--
extra : rebase_source : 013457dfb434c92134d2f244b389d21620c83595
2018-01-30 13:21:35 -05:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Paolo Amadini
f26eb575e4 Bug 1432016 - Part 1 - Add a PanelView class using a base class shared with PanelMultiView. r=Gijs
Only one method is moved to the PanelView class to simplify the keyboard navigation test.

MozReview-Commit-ID: CHB5FiT9ptn

--HG--
extra : rebase_source : ec588beae9f1208a37ce85f9d28029dfd979db24
2018-01-22 12:46:48 +00:00
Kris Maglione
aec63e140c Backed out 3 changesets (bug 1431533) for Android mochitest bustage. CLOSED TREE
MozReview-Commit-ID: 5ubE9EMQpZ9

--HG--
extra : histedit_source : df68d7595925c07d9d6e8bacc2c46e69556f479a%2C72b768b9825e20ede6603ead75f871c50dc041f7
2018-01-24 22:04:59 -08:00
Kris Maglione
30b3a49bfd Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
MozReview-Commit-ID: 8V1ZT53ReiP

--HG--
extra : rebase_source : 12b5f8c3e125111db7382eb3d7d20a99fb2c35b3
extra : absorb_source : e99fa7f6eee02e7e6cadeb898c7fcf6dac9c902a
extra : histedit_source : d0dfc31fadc2b81d341c9d0cd1efec02923c003b
2018-01-24 15:48:47 -08:00
Gijs Kruitbosch
1f11d6af6f Bug 1426250 - make tests actually pass valid mouse coordinates when testing Customize Mode, r=jaws
MozReview-Commit-ID: IglKedBqrWQ

--HG--
extra : rebase_source : a388f02b8d5e00f7e670f41d049518be1de370dc
extra : histedit_source : 8f79f40d24f5456e22787a169cc9f6ae21c03c1e
2018-01-05 21:35:27 +00:00
Tim Nguyen
e1b673bf04 Bug 1428938 - Remove legacy toolbar customization code. r=Gijs
MozReview-Commit-ID: 1ppfxI7yYJW

--HG--
extra : rebase_source : b4a2c44dd5e244c81e479e6b43e9669cc031f349
2018-01-11 16:35:17 +00:00
Paolo Amadini
1714b3aba4 Bug 1425736 - Don't show the attention badge for download failures on the application menu button. r=Gijs
MozReview-Commit-ID: A882hXl5o0

--HG--
extra : rebase_source : 1584f1141c3e8bc1aeb62559a7136dc9f0745899
2018-01-09 15:51:19 +00:00
Ian Moody
4228c58572 Bug 1425972 - Add a test for subview navigation on space keydown. r=Gijs
MozReview-Commit-ID: Hb5WlqOtibS

--HG--
extra : rebase_source : c6584d917f03824d1f4ed2b11ddb69bf3165f307
2017-12-20 16:48:19 +00:00
Ian Moody
576f8ac9fd Bug 1425972 - Add a test for interleaved arrow and tab navigation in the browser panel. r=Gijs
MozReview-Commit-ID: DBIop59CWCG

--HG--
extra : rebase_source : a14f4c16ae098758c7805482c12780452f3efdbf
2017-12-20 02:19:35 +00:00
Ian Moody
92dc6aecdf Bug 1425972 - Add a test for tab navigation in the browser panel. r=Gijs
MozReview-Commit-ID: L3C65YgRYd5

--HG--
extra : rebase_source : 9de26250aa9f18cf69818898e04b6b49b136b899
2017-12-20 00:18:19 +00:00
Tooru Fujisawa
034f9f1ec4 Bug 1424877 - Wait for the next event tick in promisePanelElementHidden in browser/components/customizableui/test/head.js. r=Gijs 2017-12-14 14:49:32 -06:00
Tooru Fujisawa
66fd8a5699 Bug 1424083 - Wait for the mouseover event instead of attribute in browser_customizemode_uidensity.js r=Paolo 2017-12-09 06:08:44 +09:00
Tooru Fujisawa
070eb80e9c Bug 1416446 - Part 0.2: Fix browser_981418-widget-onbeforecreated-handler.js to wait for events in correct order and timing. r=Paolo 2017-12-09 06:08:43 +09:00
Dorel Luca
9a04f22fb6 Backed out changeset 8ad560283f5e (bug 1416446) for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s r=backout on a CLOSED TREE 2017-12-09 18:59:48 +02:00
Dorel Luca
2761bd8ba2 Backed out changeset 56343b0de5c2 (bug 1424083) for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s r=backout on a CLOSED TREE 2017-12-09 18:58:40 +02:00
Tooru Fujisawa
b33da27b5b Bug 1424083 - Wait for the mouseover event instead of attribute in browser_customizemode_uidensity.js r=Paolo 2017-12-09 06:08:44 +09:00
Tooru Fujisawa
ef93d75551 Bug 1416446 - Part 0.2: Fix browser_981418-widget-onbeforecreated-handler.js to wait for events in correct order and timing. r=Paolo 2017-12-09 06:08:43 +09:00
Bill McCloskey
9f4d083047 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-07 12:55:24 -08:00
Neil Deakin
60e7f4183f Bug 1419925, implement a promise-oriented version of waitForClipboard, promiseClipboardChange, change a selection of tests to use this instead. Simplify some other clipboard tests that were unreliable before the fix for 1394757. r=jmaher 2017-12-07 08:39:50 -05:00
Dorel Luca
1208bc03a7 Merge mozilla-central to autoland r=merge on a CLOSED TREE
--HG--
extra : rebase_source : 5f22b0e83fd5f1b28e0c1ebbcc429c332835eb36
2017-12-07 00:27:29 +02:00
Paolo Amadini
b12ae1861e Bug 1417042 - Remove the "panelview" binding. r=Gijs
MozReview-Commit-ID: 26uQb3pteQd

--HG--
extra : rebase_source : 93263ff4f1e0d38292dbfef3f7385ddd881b25ef
extra : source : bce38a7817ee39ccd38f57f73f5acf81a41e1f69
2017-12-06 10:37:25 +00:00
Edouard Oger
7fabe73930 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : c2b534461715f8db1e6cb8bc7910311cc4ff6611
2017-11-30 16:01:40 -05:00
Edouard Oger
ae62aef149 Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
MozReview-Commit-ID: 5vBKH9NejVV

--HG--
extra : rebase_source : c160a5a1d7753d41c7afec3a822aefa9461684e6
2017-11-17 16:48:17 -05:00
Noemi Erli
e5e82c8496 Backed out changeset 932a77d8fbae (bug 1418466) for ES failures in /builds/worker/checkouts/gecko/browser/base/content/browser-sync.js r=backout on a CLOSED TREE 2017-11-30 18:44:16 +02:00
Edouard Oger
016b5734e5 Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
MozReview-Commit-ID: 5vBKH9NejVV

--HG--
extra : rebase_source : e8628aba338b19142dc63add9bb380042096053f
2017-11-17 16:48:17 -05:00
Mike Conley
4250a7d5e6 Bug 1412471 - Fix intermittent failure in browser_panelUINotifications_fullscreen_noAutoHideToolbar.js by ensuring we wait for update popup. r=Gijs
MozReview-Commit-ID: Yypy0ls4Ap

--HG--
extra : rebase_source : 5ab46c85c58da785fe4ae31ed84da58698cc47fa
2017-11-24 10:55:41 -05:00
Dorel Luca
171c255f60 Backed out changeset 1ca98c1618a6 (bug 1422106) for failing browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE 2017-12-02 02:37:38 +02:00
Edouard Oger
afb8b81041 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : 747637f3746356e3da208acc41a3629bd2597e2e
2017-11-30 16:01:40 -05:00
Dorel Luca
e07748b33c Backed out changeset 3aff028846c0 (bug 1422106) for failing syncedtabs/test/xpcshell/test_SyncedTabsDeckComponent.js and browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE
--HG--
extra : rebase_source : ec98a160ef77f13abc4b067f8836e290e3b11e21
2017-12-02 00:33:41 +02:00
Edouard Oger
2a41681065 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : b1471e1ef0163b2d3b137852d285146f5a23f1fa
2017-11-30 16:01:40 -05:00
Gijs Kruitbosch
46b1167088 Bug 1420583 - fix new tab adjacency logic when using "restore defaults", r=jaws
When using "restore defaults", Customize mode unwraps all elements. The previous implementation
of _updateNewTabVisibility assumed that elements were wrapped in <toolbarpaletteitem>s when in
customize mode, but this isn't true during a reset. The new implementation just looks for the
<toolbarpaletteitem>s and their children as necessary.

MozReview-Commit-ID: FjNJ1n8foGi

--HG--
extra : rebase_source : c9de8a2a4d4dcf191281fead320acc2ddc1321d6
2017-11-27 15:23:42 +00:00
Tawny Hoover
a33fa6a1f2 Bug 1398992 = Make 'Recently Bookmarked' in Photon panels support browser.bookmarks.openInTabClosesMenu pref. r=jaws
MozReview-Commit-ID: 3Rio9EjwilT

--HG--
extra : rebase_source : dde522b0eb65b22ee74d8dfb6d5f1d1a5489237f
2017-11-24 21:54:54 -05:00
Gijs Kruitbosch
53181787f7 Bug 1418757 - new tab button isn't adjacent to the last tab when customizing in customize mode, r=jaws
MozReview-Commit-ID: bQoNfDD2sX

--HG--
extra : rebase_source : e8afb0662e82e3b879bd3b6e28aef27d477bf92c
2017-11-22 13:49:07 +00:00
Paolo Amadini
fc23659e93 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs
MozReview-Commit-ID: IjvSZZUHUMt

--HG--
extra : rebase_source : a94e212e8af35b77806d1d62e020a511ab62e224
2017-11-21 14:21:32 +00:00
Alphan Chen
54f4537537 Bug 980904 - Disable the Character Encoding menu when document is decoded as UTF-8 without errors. r=hsivonen,emk,Gijs 2017-11-23 15:03:41 +08:00
Tooru Fujisawa
50f5bf47cd Bug 1418739 - Part 2: Remove unused delayedStartup parameter from BrowserTestUtils.waitForNewWindow. r=smaug 2017-11-21 03:41:56 +09:00
Mark Banner
ab78a2a54d Bug 1371293 - Fix instances of space-before-function-paren failures after ESLint 4 upgrade. r=mossop
MozReview-Commit-ID: 5XfdCSDjLEG

--HG--
extra : rebase_source : 96335eec91a40f893ff28a1c002653b758d8f24d
2017-11-06 13:46:21 +00:00
Gijs Kruitbosch
7cc3de1624 Bug 1388029 - remove dead CSS relating to the old panel, r=jaws
MozReview-Commit-ID: FoXjvWPc9in

--HG--
extra : rebase_source : b098e2efc8f154aaae5f4ddfd30558fb0f3299c1
2017-11-07 12:52:56 +00:00
Gijs Kruitbosch
8c1b02e3d4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws
MozReview-Commit-ID: L017kRfHfOv

--HG--
extra : rebase_source : c9dcbb76d787281ac2dcf18c59786205aeaacaf9
2017-11-07 12:15:18 +00:00
Gijs Kruitbosch
974b0a4c68 Bug 1408166 - prevent search bar popup from ever showing when browser_940307_panel_click_closure_handling is running to avoid it interfering with context menu clicks, r=florian
MozReview-Commit-ID: jyRcdAKpxR

--HG--
extra : rebase_source : 66d4452809e8b66383bf8cfb02cfc695b9ade37a
2017-11-07 10:54:10 +00:00
Jared Wein
b8ffd9d167 Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH

--HG--
extra : rebase_source : 319d160f3057173359f02adba44bdcc12a68e209
2017-10-31 14:38:15 -04:00
Coroiu Cristina
03154bfceb Backed out changeset b558ad2372bf (bug 1410666) for failing the browser-chrome on browser_all_files_referenced.js and browser_switch_to_customize_mode.js r=backout on a CLOSED TREE
Backed out changeset b558ad2372bf (bug 1410666)
2017-11-02 01:02:12 +02:00
Jared Wein
2fdc4b7cdf Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH

--HG--
extra : rebase_source : f85e763cc130a71ba0f4bda228a874ebf65b84be
2017-10-31 14:38:15 -04:00
Mark Banner
01008c7d57 Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree. r=florian
MozReview-Commit-ID: 8pidN7x6MYh

--HG--
extra : rebase_source : 6a0d6800091231fc1535223bd7fc6df0ba40d47b
2017-10-30 09:55:39 +00:00
Edouard Oger
76547f53cc Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc
MozReview-Commit-ID: APdGc9avJDw

--HG--
extra : rebase_source : aaa788be5251607ebedcb5b690da0e2a1a64e2cb
2017-10-24 14:05:52 -04:00
Sebastian Hengst
93903f0306 Backed out 2 changesets (bug 1395460) for eslint failure at browser/components/uitour/UITour.jsm:556 (no return value from arrow function). r=backout on a CLOSED TREE
Backed out changeset 0bc6d186d609 (bug 1395460)
Backed out changeset 6c028123001d (bug 1395460)
2017-10-26 23:33:04 +02:00
Edouard Oger
58876ecbe9 Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc
MozReview-Commit-ID: APdGc9avJDw

--HG--
extra : rebase_source : 9da1cea9fb6494c057bc6587a7bcbdb4ac127448
2017-10-24 14:05:52 -04:00
Felipe Gomes
43ee76c5ed Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 2qNWebBpsMY

--HG--
extra : rebase_source : b30a4492f839186584c074b82a1969973cda48e0
2017-10-17 13:39:50 -02:00
Ryan VanderMeulen
e8cd5f653b Backed out 5 changesets (bug 1407351) for causing bug 1409395 and breaking nightlies.
Backed out changeset e6ee25ad6a9f (bug 1407351)
Backed out changeset 8e04412824b5 (bug 1407351)
Backed out changeset effeee94316e (bug 1407351)
Backed out changeset a53f34a45f9b (bug 1407351)
Backed out changeset 86a360e12b8a (bug 1407351)
2017-10-17 10:07:55 -04:00
Felipe Gomes
4346cedc0e Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 8wbjdYIC3gb

--HG--
extra : rebase_source : 2ea1b77d4a9fd9c3eb17853c8ec655b309a3fa8c
2017-10-16 14:00:30 -02:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Julian Descottes
6a18c24749 Bug 1361080 - filter out hidden devtools menu items in customizableui test;r=jaws
DevTools are adding a hidden menuitem "Enable DevTools..." that will be used to
propose an onboarding screen to users. This hidden button makes a customizable ui
test fail. It needs to be filtered out.

MozReview-Commit-ID: IX4SlpDHdsT

--HG--
extra : rebase_source : e2c9e26b27b1bf8788739f8d6384c19473ffdd23
2017-10-11 17:04:22 +02:00
Erica Wright
86e507bf06 Bug 1406191 - Cleanup browser_widget_animation.js, remove event listener and close panel correctly. r=johannh
MozReview-Commit-ID: 6IjrdxnWPqa

--HG--
extra : rebase_source : 5b52caffa1d523964ee485859dd562919f5f971a
2017-10-10 15:59:14 -04:00
Dão Gottwald
8fa6f14905 Bug 1406625 - Remove leftover code and styling for <toolbarbutton type="menu-button"> r=mikedeboer
MozReview-Commit-ID: 8wBsluIMZHq

--HG--
extra : rebase_source : 8733868d1afc6a34b6e9050b6bd80f01097a66f3
2017-10-07 20:10:24 +02:00
Erica Wright
7e91455352 Bug 1390313 - Item added to the overflow menu should scale down and fade out. ui-r=epang r=Gijs
MozReview-Commit-ID: 5PxydbSfhpz

--HG--
extra : rebase_source : 3941fa6edb5e8eb0d14d6d04ad5b0d63ef1a5b84
2017-09-18 16:15:24 -04:00
Gijs Kruitbosch
19ef18501c Bug 1405720 - ensure only 1 theme is ever shown as selected in customize mode, r=jaws,johannh
The previous code here always set the `isActive` property on all themes. When writing the
patch for bug 1402981 I ran into issues because the default theme has an `isActive` property
anyway (it's a different type of object). So I tried to avoid setting `isActive` if it was
already present. Unfortunately, the result was that `isActive` values, once set, weren't
correctly updated. Worse, these values are (and were, prior to bug 1402981) persisted in
some cases.

There's no point persisting these values, all that will happen is that they'll start
mismatching the 'real' state of the world (LightweightThemeManager.currentTheme). So instead,
let's just not set the `isActive` property at all, and rely solely on the ID of the current
theme (or the default theme's ID, now that we no longer support non-lightweight-themes) to
establish whether any of the themes should appear selected or not.

MozReview-Commit-ID: 7rajS71FoQR

--HG--
extra : rebase_source : a99e04031ea9e122efdaf0436e354abe57439783
2017-10-05 15:17:12 +01:00
Edouard Oger
e29fd6597a Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : cc4d0d3ca7d12b2f83b79fc7c5db9c05f77944cf
2017-09-20 13:16:19 -04:00
Sebastian Hengst
6c9c0c17e9 Backed out changeset 9ab9bde4021f (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-10-04 21:49:30 +02:00
Edouard Oger
27e4a543cc Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : 23d246a20afd7069f095e29b2943851011813239
2017-09-20 13:16:19 -04:00
Sebastian Hengst
0b883eed0e Backed out changeset 97fdb9d392e5 (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-10-04 21:12:32 +02:00
Edouard Oger
bc78c3795e Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : 3172be8b46d44c50ea4f2c806771e10172057cf3
2017-09-20 13:16:19 -04:00
Gijs Kruitbosch
49c8b259d5 Bug 1396423 - make it possible to drop items in what visually looks like the palette but isn't, r=mikedeboer
MozReview-Commit-ID: AqBwn9ovTjT

--HG--
extra : rebase_source : 58dd5d79db16d56be502f70cd7e533a4093f1c39
2017-09-29 15:40:48 +01:00
Gijs Kruitbosch
f207243be7 Bug 1402981 - add light and dark themes to the list of themes in customize mode by default, r=jaws
MozReview-Commit-ID: 4GxPEm119Yc

--HG--
extra : rebase_source : a1a6acf06e158fd937e6b53ea65cc91c2e4d02ce
2017-09-27 22:37:19 +01:00
Mike de Boer
882fa06e25 Bug 1401991 - Ensure that we don't hide panelviews that are already reparented to another multi-view and ensure to hide other panels consistently. r=Gijs
* Harden the new `hideAllViewsExcept()` to not do erroneous things if called when
   the binding is already gone.
 * Generalize things into `hideAllViewsExcept(thisOne)`:
    - Clear `_viewShowing` in there and do the descriptionHeightWorkaround thing
      in there too,
    - For Photon panels, do all the 'current' attribute setting in there. To show
      a panel during transition, I introduced the 'in-transition' attribute.
 * I had to make sure not to over-eagerly dispatch 'ViewShowing' events, because
   that confuses some,
 * Move the temporary panel handling, which contains an ephemeral panelmultiview
   instance, internally. This cleans up the hacky, duplicate PanelUI.js code nicely.
 * Keep a local copy of `_transitionDetails` to ensure it's still there after transition,
 * Harden `_cleanupTransitionPhase()` to only clear the phase that belongs to a
   specific transition, _if_ that's passed in as an argument. This resolves any
   potential raciness that might occur when `showSubView()` is called again mid-transition.
 * Skip the UITour element visibility check when it's inside a panelview, because
   too many things need to happen and that check is too simple to be useful in
   that case.

MozReview-Commit-ID: 5HpJKs1Ny5j

--HG--
extra : rebase_source : b810e1de2dbd75932a42d68e751fdaecd9fee69a
2017-09-29 13:51:51 +02:00
Sebastian Hengst
e0196045d0 Backed out changeset 8855ba3f65ba (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-09-28 20:27:50 +02:00
Edouard Oger
c602795751 Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : 562023d6bfdb78aa2fad6c42948b57db8bc04f99
2017-09-20 13:16:19 -04:00
Mike de Boer
c0b0c75c02 Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs
MozReview-Commit-ID: 44Q9NbKEJeC

--HG--
extra : rebase_source : 4895a170b403195cd1bc7023fc905deff12c2de2
2017-09-20 14:25:58 +02:00
Andrew Halberstadt
7527e600f0 Bug 1392787 - Disable manifestparser tests using 'disabled' key instead of comment, r=jmaher
MozReview-Commit-ID: IQL7hWxQX9F

--HG--
extra : rebase_source : b78cbf7913fc1b0a27dfa085c38957e2bc2467d0
2017-08-22 16:56:02 -04:00
Gijs Kruitbosch
b7ec7b74c5 Bug 1399517 - CustomizableUI shouldn't try to insert items next to nodes that aren't in the right container, r=mikedeboer
MozReview-Commit-ID: H9KY7YQwmlQ

--HG--
extra : rebase_source : 75f92768868003280a8e187ce6f2bbc2b88dd8ca
2017-09-18 16:36:46 +01:00
Gijs Kruitbosch
069f2c2997 Bug 1391280 - store last sidebar command irrespective of whether sidebar was open, r=bgrins,mixedpuppy
MozReview-Commit-ID: HBfdW5vEZaD

--HG--
extra : rebase_source : 5058884698a2a2144b921a36abbe7c8c3a1fda52
2017-08-23 14:06:26 +01:00
Johann Hofmann
0dbe3971c5 Bug 1349552 - Part 3 - Add a test for drag space in customize mode. r=nhnt11
MozReview-Commit-ID: AiqY1J5WwYo

--HG--
extra : rebase_source : 4fb5cea18653a05f17c80595b48c8f3aae9b0d2a
2017-09-10 20:39:21 +02:00
Gijs Kruitbosch
3f3bcb5b73 Bug 1397447 - ensure the button is in the navbar by default, r=mak
MozReview-Commit-ID: H6r3dAEg4r1

--HG--
extra : rebase_source : fdb9b8d65745a57e3ac1ffa71cce10654032b177
2017-09-08 14:07:05 +01:00
Gijs Kruitbosch
ecf2be01ab Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : 11dc3f1b98f53f5897a3185253b68d2cf7d5083b
extra : source : 97f7f5175b2fc3adfb193783f7ecb70b5b9b4562
2017-09-08 14:16:36 +01:00
Sebastian Hengst
6b5abf8cab merge mozilla-central to autoland. r=merge 2017-09-07 12:40:32 +02:00
Sebastian Hengst
8eb249afcc merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00
Paolo Amadini
fe96089fe4 Bug 1387416 - Place the search bar in the customization palette for new profiles. r=Gijs
MozReview-Commit-ID: Tq8YrZWG6P

--HG--
extra : rebase_source : 2e02e0a809d08ff26291a027b73a54668d6d5f9d
2017-09-06 13:09:27 +01:00
Gijs Kruitbosch
81a14da14a Bug 1396966 - fix dnd in a test to work in small screens, r=mystor
MozReview-Commit-ID: 7xqfLc1M0PA

--HG--
extra : rebase_source : 12031eea1a7106a00a0d921825c71731fdf33ea4
2017-09-06 19:39:53 +01:00
Gijs Kruitbosch
8ec70a2c1b Bug 1393574 - fix flexible spacers not being removable in some circumstances, r=jaws
The goal of this patch is to ensure that:
- in default placements, specials have no unique ids
- in actual placements as stored by CUI, they do
- we reset the counter for those unique ids on reset.
- we re-number specials when building an area (like on startup, or when resetting),
  ensuring that the actual nodes always match the placements for a given area.
- we force saves after resetting, to ensure that the gNewElementCount is always persisted correctly.

This last part will also fix bug 1393661

MozReview-Commit-ID: HAS5J5ZSgB5

--HG--
extra : rebase_source : df62441169e07fb94e39f68a2b3e43f6ed7f464c
2017-09-06 10:02:44 +01:00
Ricky Chien
daac97d466 Bug 1349689 - Remove old preferences fork r=jaws
MozReview-Commit-ID: GNPcQGUTUKJ

--HG--
rename : browser/components/preferences/in-content-new/findInPage.js => browser/components/preferences/in-content/findInPage.js
rename : browser/components/preferences/in-content-new/searchResults.xul => browser/components/preferences/in-content/searchResults.xul
rename : browser/components/preferences/in-content-new/tests/browser_checkspelling.js => browser/components/preferences/in-content/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content-new/tests/browser_engines.js => browser/components/preferences/in-content/tests/browser_engines.js
rename : browser/components/preferences/in-content-new/tests/browser_layersacceleration.js => browser/components/preferences/in-content/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content-new/tests/browser_masterpassword.js => browser/components/preferences/in-content/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js => browser/components/preferences/in-content/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content-new/tests/browser_security-1.js => browser/components/preferences/in-content/tests/browser_security-1.js
rename : browser/components/preferences/in-content-new/tests/browser_security-2.js => browser/components/preferences/in-content/tests/browser_security-2.js
extra : rebase_source : 9adc8231c896f93f7f262a09482b44a2875bd5fd
2017-08-21 17:48:18 +08:00
Sebastian Hengst
51133fbff6 Backed out changeset df8215261c7e (bug 1349689) on request from rchien. r=backout
--HG--
rename : browser/components/preferences/in-content/findInPage.js => browser/components/preferences/in-content-new/findInPage.js
rename : browser/components/preferences/in-content/searchResults.xul => browser/components/preferences/in-content-new/searchResults.xul
rename : browser/components/preferences/in-content/tests/browser_checkspelling.js => browser/components/preferences/in-content-new/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content/tests/browser_engines.js => browser/components/preferences/in-content-new/tests/browser_engines.js
rename : browser/components/preferences/in-content/tests/browser_layersacceleration.js => browser/components/preferences/in-content-new/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content/tests/browser_masterpassword.js => browser/components/preferences/in-content-new/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content/tests/browser_permissions_dialog.js => browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content/tests/browser_security-1.js => browser/components/preferences/in-content-new/tests/browser_security-1.js
rename : browser/components/preferences/in-content/tests/browser_security-2.js => browser/components/preferences/in-content-new/tests/browser_security-2.js
2017-08-31 16:58:32 +02:00
Ricky Chien
3ff2ff68ed Bug 1349689 - Remove old preferences fork r=jaws
MozReview-Commit-ID: GNPcQGUTUKJ

--HG--
rename : browser/components/preferences/in-content-new/findInPage.js => browser/components/preferences/in-content/findInPage.js
rename : browser/components/preferences/in-content-new/searchResults.xul => browser/components/preferences/in-content/searchResults.xul
rename : browser/components/preferences/in-content-new/tests/browser_checkspelling.js => browser/components/preferences/in-content/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content-new/tests/browser_engines.js => browser/components/preferences/in-content/tests/browser_engines.js
rename : browser/components/preferences/in-content-new/tests/browser_layersacceleration.js => browser/components/preferences/in-content/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content-new/tests/browser_masterpassword.js => browser/components/preferences/in-content/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js => browser/components/preferences/in-content/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content-new/tests/browser_security-1.js => browser/components/preferences/in-content/tests/browser_security-1.js
rename : browser/components/preferences/in-content-new/tests/browser_security-2.js => browser/components/preferences/in-content/tests/browser_security-2.js
extra : rebase_source : 6f59261adcb6cd3098b3596c01c9165ad6bfc03c
2017-08-21 17:48:18 +08:00
Gijs Kruitbosch
e47e6f071c Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6

--HG--
extra : rebase_source : af8ed6b6da9adc1badbdc5016aacb877511875f0
2017-08-25 13:32:47 +01:00
Gijs Kruitbosch
58d91186ae Bug 1393133 - wait for the overflow button to be visible before activating it in tests, r=jaws
MozReview-Commit-ID: 58GGrPVufZ3

--HG--
extra : rebase_source : 325709623de03b4fd7e1414fff5bb42474194551
2017-08-24 17:25:24 +01:00
Gijs Kruitbosch
c6da57415c Bug 1389625 - clean up subview headers now that we use the title of the view instead, r=adw
The panel-subview-header is always hidden in photon (sub)panels, and so we now never show it.
Removing it avoids having to readd the old label for the bookmarks view, remove some unused
strings, and I noticed that we accidentally left the PanelUI-sidebar container which is
unused since bug 1360282.

MozReview-Commit-ID: 4ProWA1sUUs

--HG--
extra : rebase_source : e887b156f450a62cf04228db13b8584810fdf5a0
2017-08-24 14:03:15 +01:00
Wes Kocher
4ea67d0e07 Backed out changeset e774700fe070 (bug 1392787) for build bustage a=backout CLOSED TREE
MozReview-Commit-ID: FRRUDa6rIuS
2017-08-24 13:58:52 -07:00
Andrew Halberstadt
cae249f833 Bug 1392787 - Disable manifestparser tests using 'disabled' key instead of comment, r=jmaher
MozReview-Commit-ID: IQL7hWxQX9F

--HG--
extra : rebase_source : d907a5b2192687d86e3291a936c943948ed6793f
2017-08-22 16:56:02 -04:00
Jared Wein
6c68f6b603 Bug 1387313 - Allow dragging non-removable items (url bar, back/forward buttons) within their toolbar. r=Gijs
MozReview-Commit-ID: 1EQxMcLJn9J

--HG--
extra : rebase_source : 884ddb84896bec96b4cc05d2d067e8e3a69603c7
2017-08-21 14:20:40 -04:00
Gijs Kruitbosch
ace9ca19d1 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : f2c8a292c5bddb2dfde656b0f37fe2abee371ea0
2017-08-16 15:54:36 +01:00
Gijs Kruitbosch
bdf83368d1 Bug 1391616 - make migration of existing hamburger panel contents actually work, r=jaws
MozReview-Commit-ID: 4YC4BWI10YW

--HG--
extra : rebase_source : e440a1008986a81674a72b033ddbd15a35453d26
2017-08-18 13:59:32 +01:00
Gijs Kruitbosch
b308974089 Bug 1366207 - remember previous view's selection when keyboard navigating panels, r=mikedeboer
MozReview-Commit-ID: 14U7hkrBbJq

--HG--
extra : rebase_source : c6a0439d253d38a776445793b235b93ba5873f48
2017-08-15 15:21:15 +01:00
Gijs Kruitbosch
d0f97efd43 Bug 1390260 - remove old customize test, add test that checks it works in main window, r=mkaply
MozReview-Commit-ID: 9Tm8kLjxukB

--HG--
extra : rebase_source : a8d599d6e67151abdc2b65297b5cb5fcbc2dbea7
2017-08-15 17:42:16 +01:00