0183fb838b
The documentation was mentioning arc as the primary tool to push to review (and was discouraging using moz-phab). moz-phab is now much more stable and is the prefered way of pushing patches, so we shouldn't mention arc anymore. There was also a (not recommended) mention of attaching patch to Bugzilla for reviews, which I think isn't something we recommend anymore. Differential Revision: https://phabricator.services.mozilla.com/D52969 --HG-- extra : moz-landing-system : lando
1.3 KiB
Set up for code reviews
There are two things you need to do before you can get a code review, although you only need to do this once 😃
Set up to get code reviews in Phabricator
We use an online tool called Phabricator for code reviews. To create an account in Phabricator, you first need the Bugzilla account that you created earlier. If you don't have one, create it now.
⚠️ IMPORTANT: ⚠️️️
It's helpful to have the same user name in both Bugzilla and Phabricator, so that people always know how to find you.
Bugzilla's Real name field can be edited after the fact, but you cannot change Phabricator's username once the account has been created.
If you added an :ircnickname in your Bugzilla's Real name, Phabricator will use that to pre-fill the username field when you create the account. Please double check you like the proposed username, and make any corrections before you register.
Once you understand the above, please create a Phabricator account.
Set up to send code for review
In order to push your commit to Phabricator, you need to install moz-phab.