Bug 1787113 - [devtools] Move createGripMapEntry to reps test helper. r=ochameau.

The function is only used in tests, there's no
need for it to be in the Rep.

Differential Revision: https://phabricator.services.mozilla.com/D155562

devtools/client/shared/components/reps/reps/grip-entry.js

@@ -69,20 +69,9 @@ define(function(require, exports, module) {
     );
   }
 
-  function createGripMapEntry(key, value) {
-    return {
-      type: "mapEntry",
-      preview: {
-        key,
-        value,
-      },
-    };
-  }
-
   // Exports from this module
   module.exports = {
     rep: wrapRender(GripEntry),
-    createGripMapEntry,
     supportsObject,
   };
 });

devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-indexed-properties.test.js

@@ -14,7 +14,9 @@ const {
 
 const { shouldLoadItemIndexedProperties } = Utils.loadProperties;
 
-const GripEntryRep = require("devtools/client/shared/components/reps/reps/grip-entry");
+const {
+  createGripMapEntry,
+} = require("devtools/client/shared/components/test/node/components/reps/test-helpers");
 const accessorStubs = require("devtools/client/shared/components/test/node/stubs/reps/accessor");
 const gripMapStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-map");
 const gripArrayStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-array");
@@ -189,7 +191,7 @@ describe("shouldLoadItemIndexedProperties", () => {
   });
 
   it("returns false for a MapEntry node", () => {
-    const node = GripEntryRep.createGripMapEntry("key", "value");
+    const node = createGripMapEntry("key", "value");
     expect(shouldLoadItemIndexedProperties(node)).toBeFalsy();
   });
 

devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-non-indexed-properties.test.js

@@ -14,7 +14,9 @@ const {
 
 const { shouldLoadItemNonIndexedProperties } = Utils.loadProperties;
 
-const GripEntryRep = require("devtools/client/shared/components/reps/reps/grip-entry");
+const {
+  createGripMapEntry,
+} = require("devtools/client/shared/components/test/node/components/reps/test-helpers");
 const accessorStubs = require("devtools/client/shared/components/test/node/stubs/reps/accessor");
 const gripMapStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-map");
 const gripArrayStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-array");
@@ -152,7 +154,7 @@ describe("shouldLoadItemNonIndexedProperties", () => {
   });
 
   it("returns false for a MapEntry node", () => {
-    const node = GripEntryRep.createGripMapEntry("key", "value");
+    const node = createGripMapEntry("key", "value");
     expect(shouldLoadItemNonIndexedProperties(node)).toBeFalsy();
   });
 

devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-prototype.test.js

@@ -14,7 +14,9 @@ const {
 
 const { shouldLoadItemPrototype } = Utils.loadProperties;
 
-const GripEntryRep = require("devtools/client/shared/components/reps/reps/grip-entry");
+const {
+  createGripMapEntry,
+} = require("devtools/client/shared/components/test/node/components/reps/test-helpers");
 const accessorStubs = require("devtools/client/shared/components/test/node/stubs/reps/accessor");
 const gripMapStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-map");
 const gripArrayStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-array");
@@ -148,7 +150,7 @@ describe("shouldLoadItemPrototype", () => {
   });
 
   it("returns false for a MapEntry node", () => {
-    const node = GripEntryRep.createGripMapEntry("key", "value");
+    const node = createGripMapEntry("key", "value");
     expect(shouldLoadItemPrototype(node)).toBeFalsy();
   });
 

devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-symbols.test.js

@@ -14,7 +14,9 @@ const {
 
 const { shouldLoadItemSymbols } = Utils.loadProperties;
 
-const GripEntryRep = require("devtools/client/shared/components/reps/reps/grip-entry");
+const {
+  createGripMapEntry,
+} = require("devtools/client/shared/components/test/node/components/reps/test-helpers");
 const accessorStubs = require("devtools/client/shared/components/test/node/stubs/reps/accessor");
 const gripMapStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-map");
 const gripArrayStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-array");
@@ -148,7 +150,7 @@ describe("shouldLoadItemSymbols", () => {
   });
 
   it("returns false for a MapEntry node", () => {
-    const node = GripEntryRep.createGripMapEntry("key", "value");
+    const node = createGripMapEntry("key", "value");
     expect(shouldLoadItemSymbols(node)).toBeFalsy();
   });
 

devtools/client/shared/components/test/node/components/reps/grip-entry.test.js

@@ -13,11 +13,11 @@ const {
 } = require("devtools/client/shared/components/reps/reps/rep");
 
 const { GripEntry } = REPS;
-const { createGripMapEntry } = GripEntry;
 const {
   MODE,
 } = require("devtools/client/shared/components/reps/reps/constants");
 const {
+  createGripMapEntry,
   getGripLengthBubbleText,
 } = require("devtools/client/shared/components/test/node/components/reps/test-helpers");
 

devtools/client/shared/components/test/node/components/reps/test-helpers.js

@@ -97,7 +97,18 @@ function getMapLengthBubbleText(object, props) {
   });
 }
 
+function createGripMapEntry(key, value) {
+  return {
+    type: "mapEntry",
+    preview: {
+      key,
+      value,
+    },
+  };
+}
+
 module.exports = {
+  createGripMapEntry,
   expectActorAttribute,
   getSelectableInInspectorGrips,
   getGripLengthBubbleText,